Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/286#discussion_r81338875
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/WriterToBulkWriter.java
---
@@ -44,11 +45,15 @@ public void init(Map stormConf, WriterConfiguration
config) throws Exception {
}
@Override
- public void write(String sensorType, WriterConfiguration configurations,
Iterable<Tuple> tuples, List<MESSAGE_T> messages) throws Exception {
+ public BulkWriterResponse write(String sensorType, WriterConfiguration
configurations, Iterable<Tuple> tuples, List<MESSAGE_T> messages) throws
Exception {
if(messages.size() > 1) {
throw new IllegalStateException("WriterToBulkWriter expects a batch
of exactly 1");
}
messageWriter.write(sensorType, configurations,
Iterables.getFirst(tuples, null), Iterables.getFirst(messages, null));
+
+ BulkWriterResponse response = new BulkWriterResponse();
--- End diff --
What if there's an error writing? Do we still want to add the tuples to
the response as successes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
