[ 
https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sangjin Lee updated DIRMINA-527:
--------------------------------

    Attachment: DIRMINA-527.patch

A proposed patch (based on the trunk).

- Introduces IoConnector.setConnectTimeoutMillis(), and deprecates 
getConnectTimeout()/setConnectTimeout().
- Adjust the select timeout to be the smaller of the connectTimeout() or 1 
second.

Please review the changes, and accept them if you guys are OK with it.  I'd 
also like to see the changes propagated to 1.1.x (and 1.0.x too?).  Do we need 
separate JIRA issues for them?

Thanks,
Sangjin



> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
>                 Key: DIRMINA-527
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-527
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
>            Reporter: Sangjin Lee
>         Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds.  The 
> minimum value of allowed connect timeout is 1 second.  There are cases where 
> one needs to have a shorter connect timeout than 1 second and will finer 
> granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and 
> deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at 
> http://www.nabble.com/connect-timeout-to15281787s16868.html.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to