[ 
https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576998#action_12576998
 ] 

Mark Webb commented on DIRMINA-527:
-----------------------------------

What is the purpose of the MINIMUM_CONNECT_TIMEOUT field?  If it can be changed 
via a call to setConnectTimeoutMillis(long), then why have it?  Trustin 
mentions in the TODO:

"Make this configurable and automatically adjusted if the timeout a user 
specified is smaller than the current minimum connect timeout."

So if the minimum connection timeout and connection timeout can both be 
configured, why not just have one field?  The only way this makes sense to me 
is that if  you try and set the connection timeout to be lower than the minimum 
we should throw an exception.  



> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
>                 Key: DIRMINA-527
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-527
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
>            Reporter: Sangjin Lee
>            Assignee: Mark Webb
>             Fix For: 2.0.0-M2
>
>         Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds.  The 
> minimum value of allowed connect timeout is 1 second.  There are cases where 
> one needs to have a shorter connect timeout than 1 second and will finer 
> granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and 
> deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at 
> http://www.nabble.com/connect-timeout-to15281787s16868.html.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to