[ 
https://issues.apache.org/jira/browse/DIRMINA-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edouard De Oliveira updated DIRMINA-529:
----------------------------------------

    Attachment: Primitive.java

Here's a simple benchmark between the two methods. Ran under jdk1.6.0_3, output 
is :

Elapsed method 1 = 531
Elapsed method 2 = 1297



> use isPrimitive() instead of comparing the string to a list of primitives
> -------------------------------------------------------------------------
>
>                 Key: DIRMINA-529
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-529
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Stefan Ackermann
>            Assignee: Trustin Lee
>            Priority: Minor
>             Fix For: 2.0.0-M2
>
>         Attachments: mina-patch.txt, Primitive.java
>
>
> isPrimitive is a native function and should be used to determine whether a 
> class is primitive instead of comparing to a list of known primitive class 
> names

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to