[
https://issues.apache.org/jira/browse/DIRMINA-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577953#action_12577953
]
Johannes Ulfkjær Jensen commented on DIRMINA-529:
-------------------------------------------------
I find it quite surprising that the existing method is actually better! and
just to serve my own ego I extended the benchmark with my method. The results
are:
Elapsed method 1 = 178816721
Elapsed method 2 = 571406491
Elapsed method 3 = 136158715
java.vm.version=1.6.0_02-b05
java.vm.name=Java HotSpot(TM) 64-Bit Server VM
os.name=Windows Vista
true
And given that it is a mini benchmark I tried to move them around a little and
got this also:
Elapsed method 3 = 76254315
Elapsed method 1 = 190396475
Elapsed method 2 = 604831410
java.vm.version=1.6.0_02-b05
java.vm.name=Java HotSpot(TM) 64-Bit Server VM
os.name=Windows Vista
true
Not sure why this is the case. Any ideas?
Will try to attach my the extended and slightly altered benchmark.
> use isPrimitive() instead of comparing the string to a list of primitives
> -------------------------------------------------------------------------
>
> Key: DIRMINA-529
> URL: https://issues.apache.org/jira/browse/DIRMINA-529
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M1
> Reporter: Stefan Ackermann
> Assignee: Trustin Lee
> Priority: Minor
> Fix For: 2.0.0-M2
>
> Attachments: mina-patch.txt, Primitive.java, Primitive.java
>
>
> isPrimitive is a native function and should be used to determine whether a
> class is primitive instead of comparing to a list of known primitive class
> names
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
