Julien Vermillard wrote: > On Mon, 7 Apr 2008 21:39:03 +0900 (KST) > "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > >> After looking into IoSession and IoService, I ended up with the >> conclusion that we can use the same statistics type instead of >> providing different types for IoSession and IoService. >> >> The following is the list of common methods in IoSession and IoService >> (please note that getLargestXXX() methods are not present in IoSession >> yet, but I think we can add it trivially.): >> >> boolean isBothIdle(); >> boolean isIdle(IdleStatus status); >> boolean isReaderIdle(); >> boolean isWriterIdle(); >> double getLargestReadBytesThroughput(); >> double getLargestReadMessagesThroughput(); >> double getLargestWrittenBytesThroughput(); >> double getLargestWrittenMessagesThroughput(); >> double getReadBytesThroughput(); >> double getReadMessagesThroughput(); >> double getWrittenBytesThroughput(); >> double getWrittenMessagesThroughput(); >> int getBothIdleCount(); >> int getIdleCount(IdleStatus status); >> int getReaderIdleCount(); >> int getScheduledWriteBytes(); >> int getScheduledWriteMessages(); >> int getWriterIdleCount(); >> long getLastBothIdleTime(); >> long getLastIdleTime(IdleStatus status); >> long getLastIoTime(); >> long getLastReaderIdleTime(); >> long getLastReadTime(); >> long getLastWriterIdleTime(); >> long getLastWriteTime(); >> long getReadBytes(); >> long getReadMessages(); >> long getWrittenBytes(); >> long getWrittenMessages(); >> >> Should we move all these methods to the statistics class or exclude >> some? I think idleness properties are in the gray area. isXXXIdle() >> sounds like a non-statistics property, but getXXXIdleCount() sounds >> like a statistics property. And what about getLastXXXIdleTime? >> >> Any lights? >> >> Cheers, >> Hi > Hi > > I 'm ok for keeping isXXXIdle,getLastXXXIdleTime in main class, but > move getXXXIdleCount to stats.
What about getLastRead/Write/IoTime()? -- Trustin Lee - Principal Software Engineer, JBoss, Red Hat -- what we call human nature is actually human habit -- http://gleamynode.net/
