Hi, Well dependencies of a lib is always a hot subject, not as big as logging, but it is :) We can't introduce a new dep without consensus, or the angry mob will lynch us. I think common-codec is used nowhere, it's probably a mistake if it's still in parent pom.xml.
As Emm know it's a PITA to javadoc code that was forgotten and MINA suffered a lot of this. So I vetoed the code, I know it's a bit extreme, but I think it's better to commit with the javadoc than in two step (code, then doco). First because it's harder to review and if you start test driving the code before writing the minimum javadoc, you will soon be too busy tunning/fixing issues and there is a probability to forgot the javadoc. As said there, http://markmail.org/message/fbe24r5bhzvf72wx I think we don't need enormous javadoc at start, but a class header and a little explanation on each public method. Anyway, you deserve a free beer next time I go to Paris for the proxy support :) Julien On Wed, 13 Aug 2008 06:54:29 +0000 (GMT) Edouard De Oliveira <[EMAIL PROTECTED]> wrote: > Hi guys, > +1 to dependency discussion. I didn't know we could just add some > apache class in in order to avoid adding dependencies to the core. In > fact, the code used the class and i thought it was preferable to > import the dependency to avoid code dup so i modified it just before > committing. Talking abouts this, i'm relatively new to maven but > parent pom already enlists commons-codec as a dependency why do > the core child pom can't beneficiate from this dependency ? I'll > correct the headers tonight : as the svn tag says, its only the > initial commit and it was done on 2:00 AM There are other points to > discuss about the code but i wanted to commit it to trunk to give all > the opportunity to start test driving it. Cordialement, Regards, > -Edouard De Oliveira- http://tedorg.free.fr/en/main.php > > > > ----- Message d'origine ---- > De : Emmanuel Lecharny <[EMAIL PROTECTED]> > À : [email protected] > Envoyé le : Mercredi, 13 Août 2008, 8h36mn 09s > Objet : Re: svn commit: r685401 - /mina/trunk/core/pom.xml > > Julien Vermillard wrote: > > Hi, > > > > I think we need to discuss this extra core dependency, perhaps we > > need to move proxy support as a module ? > > > Is this used to do base64 decoding/encoding ? > > If so, it might be enough to import the class we need, as Julien > suggested. >
signature.asc
Description: PGP signature
