On Wed, 13 Aug 2008 06:54:29 +0000 (GMT) Edouard De Oliveira <[EMAIL PROTECTED]> wrote:
> Hi guys, > +1 to dependency discussion. I didn't know we could just add some > apache class in in order to avoid adding dependencies to the core. In > fact, the code used the class and i thought it was preferable to > import the dependency to avoid code dup so i modified it just before > committing. Talking abouts this, i'm relatively new to maven but > parent pom already enlists commons-codec as a dependency why do > the core child pom can't beneficiate from this dependency ? I'll > correct the headers tonight : as the svn tag says, its only the > initial commit and it was done on 2:00 AM There are other points to > discuss about the code but i wanted to commit it to trunk to give all > the opportunity to start test driving it. Cordialement, Regards, > -Edouard De Oliveira- http://tedorg.free.fr/en/main.php > > > > ----- Message d'origine ---- > De : Emmanuel Lecharny <[EMAIL PROTECTED]> > À : [email protected] > Envoyé le : Mercredi, 13 Août 2008, 8h36mn 09s > Objet : Re: svn commit: r685401 - /mina/trunk/core/pom.xml > > Julien Vermillard wrote: > > Hi, > > > > I think we need to discuss this extra core dependency, perhaps we > > need to move proxy support as a module ? > > > Is this used to do base64 decoding/encoding ? > > If so, it might be enough to import the class we need, as Julien > suggested. > I finally copied base64.java (and removed some references to other classes) to o.a.mina.util and remvoed all trace of commons codec from the poms. I think it was here when the asyncweb http codec was assimilated as a mina module. Julien
signature.asc
Description: PGP signature
