Hi guys,
while looking at the filters, I found a class name IoFilterAdapter. The
javadoc says that this is an abstract class (but the class is _not_
avstract ;).
So I have done some research in the code, and I found that we are using
either AbstractXXX.java classes and XXXAdapter.java classes. I think
this should be normalized in order to always use the same prefix or
postfix.
A quick grep gives :
/mina/trunk$ find . -name "*Adapter*" | grep -v .svn | grep -v target
./core/src/main/java/org/apache/mina/core/service/IoHandlerAdapter.java
./core/src/main/java/org/apache/mina/core/filterchain/IoFilterAdapter.java
./core/src/main/java/org/apache/mina/filter/codec/demux/MessageDecoderAdapter.java
./core/src/main/java/org/apache/mina/filter/codec/ProtocolDecoderAdapter.java
./core/src/main/java/org/apache/mina/filter/codec/ProtocolEncoderAdapter.java
./core/src/main/java/org/apache/mina/handler/multiton/SingleSessionIoHandlerAdapter.java
and for Abstract classes :
/mina/trunk$ find . -name "Abstract*" | grep -v .svn | grep -v target
./core/src/main/java/org/apache/mina/core/service/AbstractIoService.java
./core/src/main/java/org/apache/mina/core/service/AbstractIoConnector.java
./core/src/main/java/org/apache/mina/core/service/AbstractIoAcceptor.java
./core/src/main/java/org/apache/mina/core/session/AbstractIoSessionConfig.java
./core/src/main/java/org/apache/mina/core/session/AbstractIoSession.java
./core/src/main/java/org/apache/mina/core/buffer/AbstractIoBuffer.java
./core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
./core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoAcceptor.java
./core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoConnector.java
./core/src/main/java/org/apache/mina/core/polling/AbstractPollingConnectionlessIoAcceptor.java
./core/src/main/java/org/apache/mina/util/byteaccess/AbstractByteArray.java
./core/src/main/java/org/apache/mina/transport/socket/AbstractSocketSessionConfig.java
./core/src/main/java/org/apache/mina/transport/socket/AbstractDatagramSessionConfig.java
./core/src/main/java/org/apache/mina/proxy/AbstractProxyLogicHandler.java
./core/src/main/java/org/apache/mina/proxy/AbstractProxyIoHandler.java
./core/src/main/java/org/apache/mina/proxy/handlers/http/AbstractHttpLogicHandler.java
./core/src/main/java/org/apache/mina/proxy/handlers/http/AbstractAuthLogicHandler.java
./core/src/main/java/org/apache/mina/proxy/handlers/socks/AbstractSocksLogicHandler.java
./core/src/main/java/org/apache/mina/filter/codec/AbstractProtocolDecoderOutput.java
./core/src/main/java/org/apache/mina/filter/codec/AbstractProtocolEncoderOutput.java
./core/src/main/java/org/apache/mina/filter/stream/AbstractStreamWriteFilter.java
./core/src/test/java/org/apache/mina/transport/AbstractFileRegionTest.java
./core/src/test/java/org/apache/mina/transport/AbstractTrafficControlTest.java
./core/src/test/java/org/apache/mina/transport/AbstractBindTest.java
./core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
./core/src/test/java/org/apache/mina/filter/stream/AbstractStreamWriteFilterTest.java
./integration-beans/src/main/java/org/apache/mina/integration/beans/AbstractPropertyEditor.java
./statemachine/src/main/java/org/apache/mina/statemachine/context/AbstractStateContextLookup.java
./statemachine/src/main/java/org/apache/mina/statemachine/context/AbstractStateContext.java
./statemachine/src/main/java/org/apache/mina/statemachine/transition/AbstractTransition.java
./statemachine/src/test/java/org/apache/mina/statemachine/context/AbstractStateContextLookupTest.java
./integration-ognl/src/main/java/org/apache/mina/integration/ognl/AbstractPropertyAccessor.java
./example/src/main/java/org/apache/mina/example/proxy/AbstractProxyIoHandler.java
./example/src/main/java/org/apache/mina/example/sumup/codec/AbstractMessageEncoder.java
./example/src/main/java/org/apache/mina/example/sumup/codec/AbstractMessageDecoder.java
./example/src/main/java/org/apache/mina/example/sumup/message/AbstractMessage.java
./example/src/test/java/org/apache/mina/example/echoserver/AbstractTest.java
So I think we should rename the 6 classes using an Adapter postfix to
make them use Abstract prefix, for the sake of uniformity.
Any objection ?
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
