On Wed, Oct 8, 2008 at 12:35 PM, Emmanuel Lecharny <[EMAIL PROTECTED]>wrote:
> Hi guys, > > as I'm currently upgrading ADS from Mina 1.1.7 to 2.0.0, I'm currently > stuck in an issue without solution. We are extending the DemuxingIoHandler > class, but as three methods are now final, I can't overload them : > - messageReceived > - messageSent > - exceptionCaught > > They have been modified a while back, after a discussion between trustin > and frederic on the mailing list. here are the commit an dthe thread : > > http://mail-archives.apache.org/mod_mbox/mina-commits/200801.mbox/[EMAIL > PROTECTED] > > the thread : > http://mina.markmail.org/search/?q=messageSent%20on%20DemuxingIoHandler > > I see no reason now to have modified the methods to be final. The biggest > issue is that it forces users to write a new IoHandler instance just to > bypass the logic which is now blocked. > > I would suggest we remove the 'final' for those three method, _or_ we add > the hooks which have been mentionned, but not implemented. > > wdyt ? > I think removing the final keyword is fine. Alex
