Hi Emmanuel, I don't get your point. Version 2 gets MessageHandlers methods, so noone should change the three methods you point in DemuxingIoHandler or one could break the internal logic of the Demx.
The two methods messageSent messageReceived are forwarding to (MessageHandler) handler.handleMessage, and execeptionCaught is forwarding to (ExeceptionHandler) handler.exceptionCaught. So if you remove those "final" words, How could the user know that in DemuxingIoHandler he/she shouldn't change the internal logic ? That's was the reason of the post 9 month ago and the fix. WDYT ? Frederic ----- Original Message ----- From: "Emmanuel Lecharny" Sent: Wednesday, October 08, 2008 6:35 PM Subject: DemuxingIoHandler methods marked final Hi guys, as I'm currently upgrading ADS from Mina 1.1.7 to 2.0.0, I'm currently stuck in an issue without solution. We are extending the DemuxingIoHandler class, but as three methods are now final, I can't overload them : - messageReceived - messageSent - exceptionCaught They have been modified a while back, after a discussion between trustin and frederic on the mailing list. here are the commit an dthe thread : http://mail-archives.apache.org/mod_mbox/mina-commits/200801.mbox/[EMAIL PROTECTED] the thread : http://mina.markmail.org/search/?q=messageSent%20on%20DemuxingIoHandler I see no reason now to have modified the methods to be final. The biggest issue is that it forces users to write a new IoHandler instance just to bypass the logic which is now blocked. I would suggest we remove the 'final' for those three method, _or_ we add the hooks which have been mentionned, but not implemented. wdyt ? -- -- cordialement, regards, Emmanuel Lécharny www.iktek.com directory.apache.org
