+1 to remove it.
On Wed, Nov 5, 2008 at 3:36 AM, Julien Vermillard <[EMAIL PROTECTED]> wrote: > On Tue, 04 Nov 2008 18:24:15 +0100 > Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > >> Maarten Bosteels wrote: >> > Wasn't it an attempt to implement throttling ? >> > >> I have no idea. The documentation is pretty scarse, it's not used >> anywhere but as a parameter passed from method to method, the event >> type is never used to create an event ... >> > When requests are coming in faster than they're being processed >> > => set TrafficMask to block reading >> > >> Which part of MINA is setting this flag ? >> > => TCP buffers will fill up (OS level) >> > => TCP will tell sender to slow down >> > => OOM prevented >> > >> > when queue of incoming messages gets smaller => resume reading >> > >> May be it's a part of a big DoS protection heuristic, but it seems to >> be lagging seriously. Even the throttling filter is a bit >> incomplete ... >> >> Anyone has a better picture than me on this matter ? >> > > Abouot traffic mask & the new filter chain I think you could remove the > filtering events related to setTrafficMask. See > https://issues.apache.org/jira/browse/DIRMINA-467 I think we will > never need it. > > Julien >
