Getting compilation errors. Cannot find the TrafficMask class: /Users/elihusmails/dev/mina/mina-cleaning/core/src/main/java/org/apache/mina/core/filterchain/IoFilter.java:[25,35] cannot find symbol symbol : class TrafficMask location: package org.apache.mina.core.session
/Users/elihusmails/dev/mina/mina-cleaning/core/src/main/java/org/apache/mina/core/filterchain/IoFilterAdapter.java:[24,35] cannot find symbol symbol : class TrafficMask location: package org.apache.mina.core.session /Users/elihusmails/dev/mina/mina-cleaning/core/src/main/java/org/apache/mina/core/filterchain/IoFilterChain.java:[28,35] cannot find symbol symbol : class TrafficMask location: package org.apache.mina.core.session /Users/elihusmails/dev/mina/mina-cleaning/core/src/main/java/org/apache/mina/core/filterchain/DefaultIoFilterChain.java:[36,35] cannot find symbol symbol : class TrafficMask location: package org.apache.mina.core.session --Mark On Fri, Nov 7, 2008 at 10:54 PM, Mark Webb <[EMAIL PROTECTED]> wrote: > +1 > > On Wed, Nov 5, 2008 at 1:16 PM, Maarten Bosteels > <[EMAIL PROTECTED]> wrote: >> +1 >> >> On Wed, Nov 5, 2008 at 3:01 PM, Julien Vermillard <[EMAIL PROTECTED]>wrote: >> >>> I would like to propose : >>> - ignore setTrafficMask events in the filter chain (looks like Mark is >>> already agreeing) >>> >>> - remove setTrafficMask(..) and keep the following IoSession methods : >>> suspendRead(), suspendWrite(), resumeRead(), resumeWrite() >>> which naming is much better and add methods isWriteSuspended() >>> isReadSuspended() >>> Kill the TrafficMask class and clear all the filters of references to >>> TrafficMas, and of course fix transport classes. >>> >>> That would reduce the complexity of the thingy and make the API for >>> pausing traffic a bit more user-friendly. >>> >>> WDYT ? >>> >>> Julien >>> >>> >>> On Tue, 4 Nov 2008 18:38:15 +0100 >>> Julien Vermillard <[EMAIL PROTECTED]> wrote: >>> >>> > It was used by Read/WriteThrottlingFilter wich was removed of 2.0 : >>> > >>> http://www.nabble.com/Dropping-traffic-throttling-from-2.0-td16092085.html >>> > as said by Emm look like it's used nowhere is MINA codebase. >>> > >>> > >>> > As said by Trustin in this mail the remplacement is supposed to be >>> > o.a.m.f.executor.* and no references to setTrafficMask(); >>> > >>> > Frankly I don't understand how you can throttle read, without using >>> > setTrafficMask and disabling OP_READ on the low level socket. >>> > >>> > Julien >>> > >>> > On Tue, 4 Nov 2008 18:01:58 +0100 "Maarten Bosteels" >>> > <[EMAIL PROTECTED]> wrote: >>> > >>> > > Wasn't it an attempt to implement throttling ? >>> > > >>> > > When requests are coming in faster than they're being processed >>> > > => set TrafficMask to block reading >>> > > => TCP buffers will fill up (OS level) >>> > > => TCP will tell sender to slow down >>> > > => OOM prevented >>> > > >>> > > when queue of incoming messages gets smaller => resume reading >>> > > >>> > > I haven't tried this yet, so I could be totally wrong. >>> > > >>> > > Maarten >>> > > >>> > > On Tue, Nov 4, 2008 at 5:50 PM, Julien Vermillard >>> > > <[EMAIL PROTECTED]>wrote: >>> > > >>> > > > Hi, >>> > > > >>> > > > There is something in MINA who has hook everywhere in the core, >>> > > > it's traffic mask. As far I understand the concept, the idea is >>> > > > to be able to block read and/or writes using >>> > > > session.setTrafficMask(...), I never needed it, and I wonder who >>> > > > use it and for what exactly ? >>> > > > >>> > > > Julien >>> > > > >>> >> >
