>>> Hi guys, >>> >>> I have many corrections pending for MINA, mainly warnings being fixed >>> (thanks to Ashish's PMD page). >>> >> >> Related question: What's our take on the following two things >> 1. empty catch statements - do we keep them, or atleast add a warning >> or debug statements. Either I will suppress this check from PMD or >> will add debug statement. >> > > From what I saw in the code, there are three different cases : > - empty catch with a finally. We should simply remove the catch > - empty methods in abstract class : adding a comment should be enough > - empty statements due to a lack of code (ie, the code is not terminated) : > either we add the code, or we remove the class for the release >> >> 2. Use of import statement for javadoc - This is another problem area. >> Should we use fully qualified name for classes used only in javadoc >> (like @see), or continue to have import and use short names >> > > I would go for full qualified names in @see >> >> second one is less important. Once I get a go ahead, shall fix these >> warnings in code. >> > > Btw, there are some very bad warnings not found by PMD : potential NPE, > overriden global variables, and such ...
I am using very restricted ruleset, and now may be its time to refine and add few more. Shall workout the detailed ruleset and publish the same. - ashish
