On Thu, Aug 13, 2009 at 15:10, Bernd Fondermann<[email protected]> wrote:
> Bernd Fondermann wrote:
>> [email protected] wrote:
>>> Author: ngn
>>> Date: Tue Aug 11 20:13:13 2009
>>> New Revision: 803275
>>>
>>> URL: http://svn.apache.org/viewvc?rev=803275&view=rev
>>> Log:
>>> Add support for letting modules register for subdomains (e.g. 
>>> pubsub.vysper.org) on which all stanzas will be routed to that handler if 
>>> the "to" attribute matches the subdomain (VYSPER-172)
>>
>>> -    void setModules(List<Module> modules);
>>> +    void addModules(List<Module> modules);
>>
>> Now, the method name does not communicate the the existing list of
>> modules is not replaced, but ammended.
>>
>> What's the motivation behind this change?
>
> Wait a second... it's the other way round!! ;-)
>
> This change breaks the setter injection with spring (and that's the
> reason why it was named 'set', not 'add'...
>
> I'll try to work it out.

I commited a spring-only solution in rev 803880, while keeping the
better method name.

  Bernd

Reply via email to