On Mon, Oct 12, 2009 at 2:08 PM, Jon Folland, Nativ Ltd <[email protected]> wrote: > 1. Is there any reason why the FTPServer project does not support Socket and > ServerSocket Factories in the DataConnection classes? The reason I ask is we > would like to specify a different concrete > implementation of the Java Socket and ServerSocket classes without changing > the code base. I notice this is supported in the FTPClient class in the > Apache commons net package and it's very useful from the > FTP client perspective. Is there any chance of an update on the code?
One reason is that we create sockets in several different ways, some which I don't think would work with providing factories (like from SSLContext). But, if you can provide a patch that enables injecting factories in a consistent way I would be happy to review it for 1.1.0. > 2. Is there any reason why the DataConnection classes don't use nio server > socket channels for better scaling on the sever-side to support large volumes > of concurrent file transfers? Only lacking time :-). Again, feel free to provide a patch. /niklas
