Hi! Some thoughts should be spend how the additional atomic operations can be triggered and how to hint that to new users. I know that they can be accessed via the AttributeMap, but this isn't stated somewhere explicitly. Letting only the simple get/set/remove methods at the IoSession will confuse new users, especially if they are documented as they are at the moment.
So either remove them completely, or just state that they are convenience methods and what to do "normally" (e.g. "This is a convenience method for getAttributeMap().getAttribute(Object key)"). Maybe a link to the IoSessionAttributeMap-method would be nice, too. Just my 2 cents Steve > Emmanuel Lecharny wrote: > > I would go with only those methods (applying the KISS principle) > > Object getAttribute(Object key); > > Object setAttribute(Object key, Object value); > > Object removeAttribute(Object key); > > boolean containsAttribute(Object key); > > Set<Object> getAttributeKeys(); > > > Everything else is just overkilling, IMHO. > > -- > -- > cordialement, regards, > Emmanuel Lécharny > www.iktek.com > directory.apache.org > -------------------------------------------------------------------------- PROEMION GmbH Steve Ulrich IT Development (IT/DEV) Donaustrasse 14 D-36043 Fulda, Germany Phone +49 (0) 661 9490-601 Fax +49 (0) 661 9490-333 http://www.proemion.com/ mailto:[email protected] Geschäftsführer: Dipl. Ing. Robert Michaelides Amtsgericht-Registergericht-Fulda: 5 HRB 1867 -------------------------------------------------------------------------- E-mail and any attachments may be confidential. If you have received this E-mail and you are not a named addressee, please inform the sender immediately by E-mail and then delete this E-mail from your system. If you are not a named addressee, you may not use, disclose, distribute, copy or print this E-mail. Addressees should scan this E-mail and any attachments for viruses. No representation or warranty is made as to the absence of viruses in this E-mail or any of its attachments. AKTUELLES http://www.rmcan.de/ NEWS http://www.rmcan.com/
