> Emmanuel Lecharny wrote: > > Julien Vermillard wrote: > > That's the idea for me. > > > > kill IoSessionAttributMap, > > put a Synchronized HashMap in AbstractIoSession > > and provide only : getAttribute, setAttribute, removeAttribute, > > getAttributeKeys (could be renamed to getAttributeNames) > >
Nitpick: A ConcurrentHashMap may have a better performance. ;-) IMHO, the methods from the ConcurrentMap should be accessible, too. But maybe I'm just too critical with thread safety concerns. > We may add a listener attached to some attributes too, or to the > session. That may justify an own Map implementation, but you should redesign/clean that interface of the IoSessionAttributeMap (why do I need to give a sessions to it, the implementation ignores it anyway?). Steve
