On Jan 19, 2010, at 7:31 AM, Ashish wrote:
Well I think only Exception could be the only case needed. However,
catching generic Exception means any error, a specific Exception
caught is better.
The other odd thing is that it catches the checked exception and wraps
it in a runtime exception. This strikes me as a poor practice.
BTW, the catch(Error e) {} stuff has been caught by IntelliJ
Inspections.
Just one more thing that I noted in the class, there are no log
statements. Dom't we need them?
I'm against logging exceptions if we're re-throwing them unless we
print out some critical piece of information that cannot be discerned
by any other method. I say this from experience where I had to slog
through millions of log statements generated by one exception where
every well meaning layer printed something out.
Regards,
Alan
