On Tue, Mar 16, 2010 at 5:19 AM, Ashish <paliwalash...@gmail.com> wrote: > Is this IoListener or something specific to FtpServer? AFAIK, our > filters are part of chain and get applied at session level.
Yes, listeners are part of the FtpServer API and basically maps 1:1 to an IoAcceptor. > One suggestion is make the implementation more efficient. The current > MINA balklist filter uses List for storing IP's > and iteration through the list for each call is not efficient. So may > be ConcurrentHashMap would be good idea for storing. > However, this works fine for IP's. Need to think about Subnet and other stuff > ;) Given that these lists are usually pretty short, at least for subnets, I would see some benchmarking before making the implementation more complex. For IPs, I agree that a HashSet/HashMap or similar makes sense. /niklas
