On Thu, Mar 22, 2012 at 03:54, Mike Mahoney <[email protected]> wrote:
>
> On Mar 21, 2012, at 12:42 PM, Bernd Fondermann wrote:
>
>> But why do notable implementations like MinaStanzaListener and
>> WebSocketBackedSessionContext record the 'closed' state, but beyond that
>> do not honour it? I suggest they should simply stop whatever they do.
>
> So, basically no protocolDecoder.write(element) call if the state is closed?  
> That makes sense, but since a new MinaStanzaListener is created on every pass 
> through doDecode, does it matter?

You are right, it doesn't really matter.

>> Another way to go (and I'd prefer that ATM) would be to move close(),
>> isClosed() down to MinaStanzaListener. It is not needed anywhere else.
>
> This makes sense.  I'll move it out of XMLElementListener and only implement 
> it in MinaStanzaListener.

Great, thanks.

  Bernd

Reply via email to