On 24.04.12 17:33, Mike Mahoney wrote:


Another way to go (and I'd prefer that ATM) would be to move close(),
isClosed() down to MinaStanzaListener. It is not needed anywhere else.

This makes sense.  I'll move it out of XMLElementListener and only implement it 
in MinaStanzaListener.


Just getting back to looking at this.  On further inspection, I think we have 
to leave close() in XMLElementListener, since XMPPContentHandler holds a 
reference to XMLElementListener, and XMPPContentHandler is what needs to call 
close() from within endDocument.

Just go ahead as you seem fit.
I didn't think about this for long, so it could be rubbish, but alternatively, we could implement java.io.Closeable selectively and check with instanceof.

  Bernd

Reply via email to