[ https://issues.apache.org/jira/browse/SSHD-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476815#comment-16476815 ]
Goldstein Lyor commented on SSHD-824: ------------------------------------- [~gnt] I do not necessarily agree that {quote}This is an abuse of the Object model{quote} but I would like to understand better the reasons behind this claim. Can you provide some links to articles that provide some insights as to why this is not considered a good practice or an anti-pattern ? Please note that I am not against such a code change, I am just trying to understand why it makes the code better - is it more readable, more performant, easier to debug, etc... Thanks > Do not use anonymous inner classes to initialize collections > ------------------------------------------------------------ > > Key: SSHD-824 > URL: https://issues.apache.org/jira/browse/SSHD-824 > Project: MINA SSHD > Issue Type: Task > Reporter: Guillaume Nodet > Priority: Major > > This is an abuse of the Object model. > If needed, introduce a collection builder, especially for immutable > collections. -- This message was sent by Atlassian JIRA (v7.6.3#76005)