[
https://issues.apache.org/jira/browse/SSHD-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476996#comment-16476996
]
Goldstein Lyor commented on SSHD-824:
-------------------------------------
[~gnt] After re-reading my own comment I am getting a feeling that we are
diverging from the main purpose of this project - SSH - into realms of generic
collections and maps building utilities. While important concerns, I wonder if
it is worth investing the required effort in view of their (IMO) doubtful
contribution to the project. There are perfectly good *Apache* libraries that
we could use and from which I got inspiration for some of our code - especially
_commons-lang3, commons-collections4, commons-io_. The kind of utility you are
proposing seems more adequate for _commons-collections4_, and I personally
would not object to adding these dependencies and getting rid of the "inspired"
code - e.g., lots of stuff from _GenericUtils_, _ValidationUtils_, _IOUtils_
was inspired by the aforementioned libraries. While I do understand the
advantages of reducing the number of dependencies to a minimum, it does mean
lots of D.R.Y. code, which seems to be better located in a more generic 3rd
party library since it is not part of the main focus of this project.
I guess this is a separate discussion though...
> Do not use anonymous inner classes to initialize collections
> ------------------------------------------------------------
>
> Key: SSHD-824
> URL: https://issues.apache.org/jira/browse/SSHD-824
> Project: MINA SSHD
> Issue Type: Task
> Reporter: Guillaume Nodet
> Priority: Major
>
> This is an abuse of the Object model.
> If needed, introduce a collection builder, especially for immutable
> collections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
