[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660536#comment-16660536 ]
Goldstein Lyor commented on SSHD-849: ------------------------------------- Hi [~roberto.deandrea] I have made the changes based on your idea - pushed it into the same branch (https://github.com/lgoldstein/mina-sshd/tree/SSHD-849) + PR. Can you review + test it an see ? > Possible race condition for local port forwarding channels > ---------------------------------------------------------- > > Key: SSHD-849 > URL: https://issues.apache.org/jira/browse/SSHD-849 > Project: MINA SSHD > Issue Type: Bug > Affects Versions: 2.1.1 > Reporter: Roberto Deandrea > Priority: Major > > Hi Lyor, > We found another critical race condition sending data through local port > forwarding channels that causes loosing data bytes sent by client to target > server. > As soon as possible I will open a pull request with our potential changes to > fix this issue. > I let you know when done because I would like to know your feedback. > Hi Lyor, > We made some code changes to your proposed solution based on > ClientChannelPendingMessageQueue. > You can find our commit at > https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d > Can you review our code and give us feedback ? > If it satisfies you can you merge it in Apache SSHD master repository ? > Cheers. > Roberto > Cheers > Roberto > -- This message was sent by Atlassian JIRA (v7.6.3#76005)