FliegenKLATSCH commented on a change in pull request #119: Add support for
openssh host key certificates
URL: https://github.com/apache/mina-sshd/pull/119#discussion_r409744999
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/keyprovider/KeyPairProvider.java
##########
@@ -122,7 +132,7 @@ default KeyPair loadKey(SessionContext session, String
type)
/**
* @param session The {@link SessionContext} for invoking this load
command - may
* be {@code null} if not invoked within a session context (e.g., offline
tool).
- * @return The available {@link Iterable} key types in preferred order -
never {@code null}
Review comment:
This diff is very misleading. The line 125 was not changed, the change was
in the doc of org.apache.sshd.common.keyprovider.KeyPairProvider#getKeyTypes in
line 135, which returns a HashSet, which does NOT keep any order. The order is
important in the other "part" later in AbstractServerSession: "expected" vs.
"available" signatures...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
