lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r410044176
########## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ########## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sshd.common.config.keys; + +import java.security.PrivateKey; +import java.security.PublicKey; +import java.util.List; + +public final class OpenSshCertificate implements PublicKey, PrivateKey { Review comment: Let me suggest sort of a compromise: * Define `OpenSshCertificate` to be an **interface** that exposes only getters * Define a class `OpenSshCertificateImpl` that has getters and setters and implements `OpenSshCertificate` * Leave all the current code that checks `instanceof OpenSshCertificate`, casts to it an uses its getters as-is * Remove the builder and use the `OpenSshCertificateImpl` to create an `OpenSshCertificate` instance when needed This way the code maintains its "read-only" exposure of the getters, while at the same time providing more flexibility for mocks, future extensions, other implementations, etc.... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
