gnodet commented on issue #121: Autoformat source code URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616142503 > I am not sure how this change is supposed to work > > * Does one commit changes only after the build ? I find this slightly counter-intuitive as it means that what I see in the IDE is not necessarily what is committed. The formatting happens during the maven build in the process-sources phase, so before the compilation / tests. What you see in the IDE will always be what you commit, as the formatting is done done during the commit phase, but during the maven build. Checkstyle runs during the maven build, so you can also commit things that do fail in maven, even if the IDE does not complain. The difference is that with this change, you won't get a failure, but it will reformat the source to adhere to the rules instead of simply failing with sometimes very cryptic or unintuitive formatting problems. > * Personally, I am not so comfortable with the result - I find it difficult to read due to the indentations The indentation is mostly the same afaik. If you refer to the 8 spaces continuation indentation instead of the 4 spaces, it can be changed. All formatting rules can be changed at will using the `sshd-eclipse-formatter-config.xml` config file in the root. > *I think we are losing some features that checkstyle provides - it's not only about indentation Checkstyle is about the style. We have PMD for semantics. Honestly, i find checkstyle very tedious to work with.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
