gnodet commented on issue #121: Autoformat source code URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616161282 > > > All formatting rules can be changed at will using the sshd-eclipse-formatter-config.xml config file in the root. > > What about Intellij ? Is it affected in any way (since the file is called `sshd-eclipse-formatter-config.xm`) The eclipse formatter is used during the build, but this has nothing to do with the eclipse IDE. > > > > Checkstyle is about the style. We have PMD for semantics. > > I think that's inaccurate - the way I configured the tools is to **complement** each other - they each have some feature that the other does not. Furthermore, 'style' is not limited to indentation. IMO, there are many useful extra checks that checkstyle applies (see my reply on the dev mailing list) Not sure what you refer to exactly here. I think the formatting takes into accounts all style related rules, spaces, braces, indentation, etc... You may have seen the changes in indentation, but that only means all other are the same. The effect is that if you ommit a space or add spaces that would have been rejected by checkstyle, with this commit, they would simply be added / removed to follow the rules. Same for long lines, braces, etc... > > > > Honestly, i find checkstyle very tedious to work with. > > Matter of preference - I find it very useful :-) - I guess I will adjust to not having it... I think you'll still have all the rules enforced. The only difference is that it will be done for you, instead of rejecting the build and force the developper to go back to the source code and fix the problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
