[ 
https://issues.apache.org/jira/browse/SSHD-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158986#comment-17158986
 ] 

Guillaume Nodet commented on SSHD-1035:
---------------------------------------

A maybe slightly better possibility at: 
[https://gist.github.com/gnodet/8771cc23e1c1a2e063ef01c16c54c61a]

It removes the pain of having to go to the inner enum to find the property 
definition, so it's easier for completion, javadoc, etc... and most 
importantly, it brings all property definitions into a single class.

> Move property definitions to FactoryManager
> -------------------------------------------
>
>                 Key: SSHD-1035
>                 URL: https://issues.apache.org/jira/browse/SSHD-1035
>             Project: MINA SSHD
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Priority: Major
>
> There are a bunch of properties (and their default values) which are defined 
> on various places.  This makes finding configurable properties almost 
> impossible.
> * {{InvertedShellWrapper.PUMP_SLEEP_TIME}}
> * {{SshAgentServer.CHANNEL_OPEN_TIMEOUT_PROP}}
> * {{DefaultForwardingFilter.FORWARD_REQUEST_TIMEOUT}}
> * {{SessionHeartbeatController.SESSION_HEARTBEAT_TYPE}}
> * {{SessionHeartbeatController.SESSION_HEARTBEAT_INTERVAL}}
> * {{ScpClient.SCP_EXEC_CHANNEL_OPEN_TIMEOUT}}
> * {{ScpClient.SCP_EXEC_CHANNEL_EXIT_STATUS_TIMEOUT}}
> * {{SftpClient.NAME_DECODING_CHARSET}}
> * {{SftpFileSystemProvider.[.*]_PROP_NAME}}
> * {{ClientAuthenticationManager.PREFERRED_AUTHS}}
> * {{ClientAuthenticationManager.PASSWORD_PROMPTS}}
> * {{BufferUtils.HEXDUMP_CHUNK_SIZE}}
> * {{AgentServerProxy.AUTH_SOCKET_TIMEOUT}}
> * {{X11ForwardSupport.CHANNEL_OPEN_TIMEOUT_PROP}}
> * {{X11ForwardSupport.X11_[.*]}}
> * {{SftpRemotePathChannel.COPY_BUFSIZE_PROP}}
> * {{AbstractConnectionService.MAX_CONCURRENT_CHANNELS_PROP}}
> * ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to