[
https://issues.apache.org/jira/browse/SSHD-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159363#comment-17159363
]
Lyor Goldstein commented on SSHD-1035:
--------------------------------------
In principle I agree with the problem description, however I am not sure that a
central location is feasible - unless it is inside `sshd-common` since code in
different modules needs to access these properties. I am not sure that using
"typed" properties is a good idea since our `PropertyResolverUtils` is very
"forgiving" - e.g., when looking for an integer the code is willing to accept
any _Number_ or string. Other properties allow a variety of types (e.g.,
welcome banner source). I am not sure it would be wise to lose this capability.
That being said, perhaps a better solution would be to have a class named
`XxxModuleProperties` in each module - e.g., `CommonModuleProperties` in
_sshd-common_, `CoreModuleProperties` in _sshd-core_, etc.... These classes
would contain the relevant properties definitions and documentation (perhaps
grouped in inner enum(s)).
> Move property definitions to FactoryManager
> -------------------------------------------
>
> Key: SSHD-1035
> URL: https://issues.apache.org/jira/browse/SSHD-1035
> Project: MINA SSHD
> Issue Type: New Feature
> Reporter: Guillaume Nodet
> Priority: Major
>
> There are a bunch of properties (and their default values) which are defined
> on various places. This makes finding configurable properties almost
> impossible.
> * {{InvertedShellWrapper.PUMP_SLEEP_TIME}}
> * {{SshAgentServer.CHANNEL_OPEN_TIMEOUT_PROP}}
> * {{DefaultForwardingFilter.FORWARD_REQUEST_TIMEOUT}}
> * {{SessionHeartbeatController.SESSION_HEARTBEAT_TYPE}}
> * {{SessionHeartbeatController.SESSION_HEARTBEAT_INTERVAL}}
> * {{ScpClient.SCP_EXEC_CHANNEL_OPEN_TIMEOUT}}
> * {{ScpClient.SCP_EXEC_CHANNEL_EXIT_STATUS_TIMEOUT}}
> * {{SftpClient.NAME_DECODING_CHARSET}}
> * {{SftpFileSystemProvider.[.*]_PROP_NAME}}
> * {{ClientAuthenticationManager.PREFERRED_AUTHS}}
> * {{ClientAuthenticationManager.PASSWORD_PROMPTS}}
> * {{BufferUtils.HEXDUMP_CHUNK_SIZE}}
> * {{AgentServerProxy.AUTH_SOCKET_TIMEOUT}}
> * {{X11ForwardSupport.CHANNEL_OPEN_TIMEOUT_PROP}}
> * {{X11ForwardSupport.X11_[.*]}}
> * {{SftpRemotePathChannel.COPY_BUFSIZE_PROP}}
> * {{AbstractConnectionService.MAX_CONCURRENT_CHANNELS_PROP}}
> * ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
