FliegenKLATSCH commented on a change in pull request #164:
URL: https://github.com/apache/mina-sshd/pull/164#discussion_r486450085
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/signature/Signature.java
##########
@@ -93,4 +93,12 @@ default void update(SessionContext session, byte[] hash)
throws Exception {
* @throws Exception If failed to calculate the signature
*/
byte[] sign(SessionContext session) throws Exception;
+
+ /**
+ * Get the original ssh name of the signature algorithm
+ * Only used for ssh cert variants, defaults to null
+ */
+ default String getSshAlgorithmName() {
+ return null;
+ }
Review comment:
Because I am too lazy to fill it for _all_ algorithms.. For most it
doesn't make a difference.
But can do it for all.. Or we do it like in the original PR - handing in a
default, would that also be an option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
