lgoldstein commented on a change in pull request #164:
URL: https://github.com/apache/mina-sshd/pull/164#discussion_r486801409
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureRSA.java
##########
@@ -52,8 +52,21 @@
private int verifierSignatureSize = -1;
+ private final String sshAlgorithmName;
+
protected SignatureRSA(String algorithm) {
+ this(algorithm, null);
Review comment:
Since you are using `ValidateUtils.checkNotNullAndNotEmpty` this
constructor is invalid since whoever uses it will get an exception.
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureRSA.java
##########
@@ -52,8 +52,21 @@
private int verifierSignatureSize = -1;
+ private final String sshAlgorithmName;
+
protected SignatureRSA(String algorithm) {
+ this(algorithm, null);
Review comment:
Since you are using `ValidateUtils.checkNotNullAndNotEmpty` this
constructor is invalid since whoever uses it will get an exception.
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureRSA.java
##########
@@ -52,8 +52,21 @@
private int verifierSignatureSize = -1;
+ private final String sshAlgorithmName;
+
protected SignatureRSA(String algorithm) {
+ this(algorithm, null);
Review comment:
Since you are using `ValidateUtils.checkNotNullAndNotEmpty` this
constructor is invalid since whoever uses it will get an exception.
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureRSA.java
##########
@@ -52,8 +52,21 @@
private int verifierSignatureSize = -1;
+ private final String sshAlgorithmName;
+
protected SignatureRSA(String algorithm) {
+ this(algorithm, null);
Review comment:
Since you are using `ValidateUtils.checkNotNullAndNotEmpty` this
constructor is invalid since whoever uses it will get an exception.
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureRSA.java
##########
@@ -52,8 +52,21 @@
private int verifierSignatureSize = -1;
+ private final String sshAlgorithmName;
+
protected SignatureRSA(String algorithm) {
+ this(algorithm, null);
Review comment:
Since you are using `ValidateUtils.checkNotNullAndNotEmpty` this
constructor is invalid since whoever uses it will get an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
