[ 
https://issues.apache.org/jira/browse/SSHD-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291513#comment-17291513
 ] 

Thomas Wolf commented on SSHD-1132:
-----------------------------------

I find that extension not 100% clearly defined in the IETF draft. For instance 
SSH_FXP_READLINK has to return "dummy attributes". But with encoding failures, 
it would make sense to return in the attributes 
SSH_FILEXFER_ATTR_FLAGS_TRANSLATION_ERR and the UNTRANSLATED_NAME if the link 
target cannot be encoded as requested.

I also wonder what a Java sftp server would be supposed to do with that option 
anyway. Java delivers file names a strings, so always Unicode. It's not clear 
to me under what circumstance a Java sftp server would ever send that 
filename-charset extension. I suppose adding support for this in Apache MINA 
sshd would be on the client side only?

(However, a server runningĀ  on OS X needs to normalize link targets to NFC to 
conform to "When UTF-8 is sent, the shortest valid UTF-8 encoding of the 
UNICODE data MUST be used." OS X uses NFD.)

> Add support for SFTP "filename-charset" extension
> -------------------------------------------------
>
>                 Key: SSHD-1132
>                 URL: https://issues.apache.org/jira/browse/SSHD-1132
>             Project: MINA SSHD
>          Issue Type: Improvement
>            Reporter: Lyor Goldstein
>            Assignee: Lyor Goldstein
>            Priority: Minor
>              Labels: SFTP, sftp
>
> See https://tools.ietf.org/html/draft-ietf-secsh-filexfer-13#page-16



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to