alex-sherwin commented on pull request #119: URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-835889962
Hi @tomaswolf Yes this is the problem, I had debugged the native OpenSSH client code and checked the raw buffer differences to come down to that same conclusion I haven't put together a formal PR for this yet but I plan to soon, but I'm still not entirely sure what the right process is for determining the right value to put here for the algo value. I can make it work with known, contrived values (`rsa-sha2-512` for rsa client certs and `ssh-ed25519` for ed25519 client certs), but I haven't spent the time yet to find out the "right" way to determine this value dynamically yet The followup, once that's determined, will be how to properly unit test it since mina sshd server-side doesn't support client cert based auth. I haven't investigated yet if it's plausible to unit test the client behavior in isolation or if the project will want complete end-to-end testing, which may require me to implement the server-side portion of this as well (I hope not, as I don't need that functionality) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
