alex-sherwin commented on pull request #119: URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836683227
@gnodet @tomaswolf Sure, I didn't mean to start a whole thread here, was originally just looking to solicit info on what may be missing from this PR's original changes Since it sounds like you're receptive to this change in general I'm happy to put together an initial PR tonight. I did see that testcontainers was already in use for the SFTP performance test, looked like a one-off thing to me so I wasn't sure if it was something the project wanted to adopt or not. But I totally agree that I think it makes sense to test against OpenSSH sshd so that you're testing mina client code against a different implementation. I have a lot of experience using testcontainers so I'm more then happy to use it in some unit tests for this PR Thanks for your input so far -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
