lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871741043
> There was some refactoring grouping together isolated variables related to KEX (SessionCountersDetails/SessionKexDetails). Probably not needed to implement strict KEX. Here I have to disagree with you. My open source philosophy puts a great emphasis on the word "open". This is why 99.999% of the code uses `public` or `protected` visibility. Furthermore, I want to provide the user as much flexibility as possible as well as the maximum information with the least amount of effort for the user. That being said, the 2 classes you mention make testing very easy since they exposes the internal counters in an easy-to-use manner instead of having to sub-class the session in a cumbersome manner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
