tomaswolf commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871820292
As you're a committer and PMC member I cannot stop you from merging this,
but I fundamentally disagree with this change.
A PR should have one concern ("provide strict KEX"), and commits in a PR
also should have one concern ("implement strict KEX functionality", "provide
unit tests for strict KEX", "provide container tests (integration tests) for
strict KEX").
Please note that OpenSSH 8.9 does **not** have the strict KEX feature. The
first public version that does have it is OpenSSH 9.6. See the [OpenSSH release
notes](https://www.openssh.com/releasenotes.html). Or did you build your own
version of 8.9 with the strict KEX patch applied?
As for the reformatting: of course I don't _know_ how it happened... it
looks to me as if your IDE reformatted the whole file to line length 80 on
save. We normally use a line length of 120 characters.
Implementing strict KEX is about a 20, maybe 30-line change in
AbstractSession. And then there may be hundreds of lines for tests. I'll try to
put together a simpler PR over New Year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
