ianjoneill opened a new pull request, #639: URL: https://github.com/apache/mina-sshd/pull/639
Adds the capability to use Bouncy Castle for EdDSA / Ed25519 support if it's available, so that you don't have to depend on the `net.i2p.crypto` EdDSA library. If the `net.i2p.crypto` EdDSA library is available, that is used in preference to Bouncy Castle - to ensure there is no change for those that are already running with both providers available. I do not believe this introduces any API breaking changes - all the existing static methods and `net.i2p.crypto` specific classes are still in place. Scenarios tested - in all situations on the Mina side `ssh-ed25519` was configured as the only available signature factory and an Ed25519 key was used for authentication: * Mina as SFTP client with only `net.i2p.crypto` available, connecting to OpenSSH SFTP server * Mina as SFTP client with only Bouncy Castle available, connecting to OpenSSH SFTP server * Mina as SFTP client with both `net.i2p.crypto` and Bouncy Castle available, connecting to OpenSSH SFTP server * Mina as SFTP server generating an Ed25519 host key with only `net.i2p.crypto` available, connecting with OpenSSH SFTP client * Mina as SFTP server generating an Ed25519 host key with only Bouncy Castle available, connecting with OpenSSH SFTP client * Mina as SFTP server generating an Ed25519 host key with both `net.i2p.crypto` and Bouncy Castle available, connecting with OpenSSH SFTP client I have not added or attempted to run/fix any of the tests in the project yet - if you are happy with the approach taken here I will work on adding and fixing tests. The generic nature of this implementation makes adding native Java 15+ support with multi-release JARs quite straight forward - once a suitable maven setup has been configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
