tomaswolf commented on PR #639: URL: https://github.com/apache/mina-sshd/pull/639#issuecomment-2558210611
@ianjoneill : I took a closer look. Impressive work; looks very good. You did a great job integrating this into this awfully complex maze of classes dealing with security providers and key handling. If you have some additional tests to add, by all means do so. The PR needs to be rebased onto current master. The [documentation about keys](https://github.com/apache/mina-sshd/blob/master/docs/standards.md#signatureskeys) would need to be extended to day that `ssh-ed25519` is supported if `net.i2p.crypto.eddsa` or Bouncy Castle are present (and net.i2p is used if both are available). Other places to update: * https://github.com/apache/mina-sshd/blob/master/docs/files-parsing.md#pemopenssh (last sentence in that paragraph) * https://github.com/apache/mina-sshd/blob/master/docs/dependencies.md#ed25519-java (completely optional and not recommended, but may have some appeal if someone doesn't have or want Bouncy Castle and prefers to include the small net.i2p library despite it having a security issue) Apart for that, this looks good to go in. I ran the JGit tests with an Apache MINA sshd snapshot including this PR and with the net.i2p registrar disabled, and they all worked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
