tomaswolf commented on code in PR #639:
URL: https://github.com/apache/mina-sshd/pull/639#discussion_r1901153571
##########
sshd-common/src/main/java/org/apache/sshd/common/util/security/SecurityUtils.java:
##########
@@ -606,99 +609,155 @@ public static RandomFactory getRandomFactory() {
* @return {@code true} if EDDSA curves (e.g., {@code ed25519}) are
supported
*/
public static boolean isEDDSACurveSupported() {
+ return getEdDSASupport().isPresent();
+ }
+
+ public static boolean isNetI2pCryptoEdDSARegistered() {
+ register();
+ return isProviderRegistered(EDDSA);
+ }
+
+ public static Optional<EdDSASupport<?, ?>> getEdDSASupport() {
if (isFipsMode()) {
- return false;
+ return Optional.empty();
Review Comment:
Not sure. I don't see EdDSA listed as an "approved algorithm" in the [BC
FIPS Security Policy
2.0.0](https://downloads.bouncycastle.org/fips-java/docs/BC-FJA-SecurityPolicy-2.0.0.pdf).
It's still listed in "Table 6 - Non-Approved Algorithms Not Allowed in the
Approved Mode of Operation".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
