Thanks Gary for the clarifying. My concern is, in whatever way it works, we should support the conventional practices like the mvn command. Otherwise it will break developers and library users. Think about how downstream projects would use this library, they may copy/fork your tests in their codebases and do some changes or have some their own tests relying on the library, then execute them as part of their building systems.
Regards, Kai -----Original Message----- From: Gary [mailto:ga...@apache.org] Sent: Friday, July 22, 2016 7:29 AM To: dev@mnemonic.incubator.apache.org Subject: Re: [VOTE] Release of Apache Mnemonic-0.2.0-incubating [rc2] Hi Kai, The test framework could put all test cases to initialize and run at same time in any order on one or multiple processes, that will trigger the issue of nvml to fail so as a workaround, we explicitly list a set of test commands instead, user can use operate "&&" to concatenate all those of test command if want a single command to test in a whole. The reason why it is a workaround is that it is introduced by external native library i.e. nvml, we can consider replacing nvml with other native memory service e.g. pmalloc if desired. B.R, +Gary On 7/21/2016 3:51 PM, Zheng, Kai wrote: >>> Sorry that the "$ mvn clean package install -DskipTests=false" >>> should be removed from README.md > Sorry it looks to me that the cmd instruction is pretty good to use. The fix > could be to work around the real test? Possibly misunderstanding and please > correct me. Thx. > > Regards, > Kai > > From: Gary [mailto:ga...@apache.org] > Sent: Friday, July 22, 2016 12:03 AM > To: dev@mnemonic.incubator.apache.org > Subject: Re: [VOTE] Release of Apache Mnemonic-0.2.0-incubating [rc2] > > > Hi JiaJia, > > Thanks for your verification. > > Sorry that the "$ mvn clean package install -DskipTests=false" should be > removed from README.md because it is a known issue from NVML that vmem > randomly doesn't work if one instance application create multiple instances > of vmem (depends on unit test framework run-time), (Note that this issue is > also verified by independent C test application, There are also some comments > mentioned this issue). > > I will remove the paragraph as a workaround and then preparing rc3 for > voting, Thanks! > > B.R, > +Gary > > Please do those unit test separately as readme.md shown, On 7/21/2016 > 12:52 AM, Li, Jiajia wrote: > > Hi all, > > > > > > > > Items checked: > > > > * Verified checksums and signature of source package > > > > * Built successfully with Maven 3.3.9 and Java 8 > > > > > > > > But when running the unit tests: > > > > $ mvn clean package install -DskipTests=false > > > > > > > > Hang on following test, can't continue... > > > > > > > > Perf.Level Changed: SLOW -> FASTEST > > > > Allocator Changed: FASTEST, 30A3107A -> 1B68DDBD > > > > Random number generator seed is 1469085466047 > > > > [Seq.1] size 1529749 - 1529749, (Correct) > > > > [Seq.2] size 1187156 - 1187156, (Correct) > > > > [Seq.3] size 1800995 - 1800995, (Correct) > > > > [Seq.4] size 1188585 - 1188585, (Correct) > > > > [Seq.5] size 1544599 - 1544599, (Correct) > > > > > > Thanks > > Jiajia > > > > > > > > -----Original Message----- > > > > From: Gary [mailto:ga...@apache.org] > > > > Sent: Tuesday, July 19, 2016 3:27 AM > > > > To: > dev@mnemonic.incubator.apache.org<mailto:dev@mnemonic.incubator.apache > .org><mailto:dev@mnemonic.incubator.apache.org><mailto:d...@mnemonic.in > cubator.apache.org> > > > > Subject: [VOTE] Release of Apache Mnemonic-0.2.0-incubating [rc2] > > > > > > > > Hi all, > > > > > > > > This is a call for a releasing Apache Mnemonic 0.2.0-incubating, release > candidate 2. This is the second release of Mnemonic incubating. > > > > > > > > The source tarball, including signatures, digests, etc. can be found at: > > > > https://dist.apache.org/repos/dist/dev/incubator/mnemonic/0.2.0-incuba > ting-rc2/src/ > > > > > > > > The tag to be voted upon is v0.2.0-incubating: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-mnemonic.git;a=sho > rtlog;h=refs/tags/v0.2.0-incubating > > > > > > > > The release hash is a3a1f1b1d3430fc9e7c15db2525d8a22f683ed20: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-mnemonic.git;a=com > mit;h=a3a1f1b1d3430fc9e7c15db2525d8a22f683ed20 > > > > > > > > Release artifacts are signed with the following key: > > > > https://dist.apache.org/repos/dist/dev/incubator/mnemonic/KEYS > > > > > > > > KEYS file available: > > > > https://dist.apache.org/repos/dist/dev/incubator/mnemonic/KEYS > > > > > > > > For information about the contents of this release, see: > > > > https://dist.apache.org/repos/dist/dev/incubator/mnemonic/0.2.0-incuba > ting-rc2/CHANGES.txt > > > > > > > > The vote will be open for 72 hours. > > > > Please download the release candidate and evaluate the necessary items > including checking hashes, signatures, build from source, and test. The > please vote: > > > > > > > > [ ] +1 Release this package as apache-mnemonic-0.2.0-incubating > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 Do not release this package because because... > > > > > > > > Thanks, > > > > Gary > > > > > >
