[
http://jira.codehaus.org/browse/MOJO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_95339
]
Grégory Joseph commented on MOJO-527:
-------------------------------------
Hi Tom,
I applied the patch locally, seems fine - I simplified a couple of things
(inline method calls and variable declarations) to make things (imho) more
readable.
However, I'd like to understand one more thing: why the use of SourceMapping ?
afaict, it has nothing to do with the SourceInclusionScanner right? I agree
that using it makes the mojo configuration simpler (.jrxml instead of a regex
pattern) but
- i really dont like the
mapping.getTargetFiles( targetDirectory, srcName ).iterator().next();
bit. Indeed we can assume the getTargetFiles will return a single element set
everytime, its really not elegant and unclear
- if we keep this, then the parameters sourcePattern and targetPattern need to
be renamed, since they're not patterns anymore.
Yes I'm nitpicking, one of my favorite sports :) Let me know what you think and
i'll commit!
> Compile JasperReports only if modified
> --------------------------------------
>
> Key: MOJO-527
> URL: http://jira.codehaus.org/browse/MOJO-527
> Project: Mojo
> Issue Type: Improvement
> Components: jasperreports
> Reporter: M.H. Avegaart
> Assignee: Grégory Joseph
> Attachments: MOJO-527-jasperreports-maven-plugin.patch,
> MOJO-527-jasperreports-maven-plugin.patch
>
>
> The Maven 2 JasperReports Plugin compiles reports unconditionally.
> Please change this so the source .jrxml file is only compiled if the target
> .jasper file is older than the source file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
