[
http://jira.codehaus.org/browse/MOJO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_95341
]
Tom Schwenk commented on MOJO-527:
----------------------------------
Gregory-
Unfortunately, yes, the SourceInclusionScanner depends on the SourceMapping
(see scanner.addSourceMapping( mapping ) on line 330) which is what enables the
inclusionScanner to do its magic.
I'm not fond of the getTargetFiles() method returning a Collection instead of a
single entity either, but I guess I can understand it in the context of other
compiler programs that might output several targets from one source. And the
way that the compiler plugin uses it, they don't need to access the destination
file name directly because javac automatically creates the output file. Our
problem is that the Jasper compiler requires us to pass in the full destination
filename or else it will create the output in the same directory as the source.
So, while I agree that one line is a little ugly, my feeling is that it's
better than the alternative of writing our own inclusion scanner.
As for the sourcePattern and targetPattern properties, I agree they should be
renamed. sourceFileExt and targetFileExt?
> Compile JasperReports only if modified
> --------------------------------------
>
> Key: MOJO-527
> URL: http://jira.codehaus.org/browse/MOJO-527
> Project: Mojo
> Issue Type: Improvement
> Components: jasperreports
> Reporter: M.H. Avegaart
> Assignee: Grégory Joseph
> Attachments: MOJO-527-jasperreports-maven-plugin.patch,
> MOJO-527-jasperreports-maven-plugin.patch
>
>
> The Maven 2 JasperReports Plugin compiles reports unconditionally.
> Please change this so the source .jrxml file is only compiled if the target
> .jasper file is older than the source file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
