This is really patch b.

Maybe I should explain what patch B does:

if you have 
<plugin>
  <groupId>org.codehaus.mojo</groupId>
  <artifactId>findbugs-maven-plugin</artifactId>
</plugin>

At present you will not get any XML output (xdoc or otherwise)

With patch-b you will get the native XML output in in target/findbugs.xml

Thus not breaking anyone.

<plugin>
  <groupId>org.codehaus.mojo</groupId>
  <artifactId>findbugs-maven-plugin</artifactId>
  <configuration>
    <xmlOutput>true</xmlOutput>
  </configuration>
</plugin>

At present you will get xml output in the xdocs format in
target/findbugs.xml

With patch-b you will get xml output in the xdocs format in
target/findbugs-maven.xml 
_AND_ xml output in the native format in target/findbugs.xml

(OK so this breaks anyone who is relying on the xdocs format being called
findbugs.xml... but they can get the previous behaviour by doing...) 

<plugin>
  <groupId>org.codehaus.mojo</groupId>
  <artifactId>findbugs-maven-plugin</artifactId>
  <configuration>
    <xmlOutput>true</xmlOutput>
    <nativeXmlOutput>false</nativeXmlOutput>
  </configuration>
</plugin>

The reason for this choice is that way the name of the native format stays
constant... it would not be a big deal to me if we went with native always
to findbugs-native.xml but I'd prefer to signal that the xdocs format is not
the native xml format.

-Stephen.


dvicente wrote:
> 
> Hi,
> 
> the third option will be :
> 
> - by default, Findbugs plugin generate the existing xdoc format file
> - if nativeXmlOutput set as true, Findbugs plugin let Findbugs to generate 
> the real xml report
> - findbugs plugin provides an object model to retreive data from native or
> not xml report
> 
> 
> Stephen Connolly wrote:
>> 
>> Option B does not break compatibility.
>> 
>> In fact it leaves the xdocs report unchanged and provides a mechanism to
>> generate the real xml report.
>> 
>> Option A was really a stop-gap
>> 
>> -Stephen.
>> 
>> Garvin LeClaire-2 wrote:
>>> 
>>> It will be option A in order to keep compatibility.
>>> I am travelling this week so I will fix it on the weekend and post a
>>> snapshot when I am back.
>>> 
>>> I am in the midst of refactoring the plug-in and do have plans to also
>>> use
>>> other reporters.  I will need to submit some of my patches to FindBugs
>>> first
>>> before this can be done with the plug-in
>>> 
>>> 
>>> 
>>> -- 
>>> Regards,
>>> 
>>> 
>>> Garvin LeClaire
>>> [EMAIL PROTECTED]
>>> 
>>> 
>>> 
>>> On 8/12/07, Stephen Connolly <[EMAIL PROTECTED]> wrote:
>>>>
>>>>
>>>> Just to let you know (as the submitter of the JIRA)
>>>>
>>>> We'd prefer if patch-b (which allows generating xml report) or similar
>>>> was
>>>> used rather than changing the xdoc format.
>>>>
>>>> It is a pain maintaining two sets of parsers, and the xml report
>>>> contains
>>>> all the information we require anyway.
>>>>
>>>> If the stream handling in patch-b is not as tidy as you'd like, I can
>>>> refactor the stream-open/close code to within Reporter and produce a
>>>> patch-c.
>>>>
>>>> -Stephen Connolly
>>>>
>>>> (obviously i'm +1 but I know I have no standing (yet) in this community
>>>> ;-)
>>>> )
>>>>
>>>> dvicente wrote:
>>>> >
>>>> > +1 for me
>>>> >
>>>> > "add extra informations" is not a problem.
>>>> >
>>>> > 2007/8/10, Garvin LeClaire <[EMAIL PROTECTED]>:
>>>> >>
>>>> >>  There has been a request to add extra information to the Findbugs
>>>> in
>>>> the
>>>> >> JIRA <http://jira.codehaus.org/browse/MOJO-882>
>>>> >>  Please take a look and forward any questions.
>>>> >>
>>>> >> I want to make sure we do not break any other plug-ins with
>>>> dependencies
>>>> >> on the current layout.
>>>> >>
>>>> >>
>>>> >>
>>>> >>
>>>> >> --
>>>> >>
>>>> >> Regards,
>>>> >>
>>>> >>
>>>> >>
>>>> >> Garvin LeClaire
>>>> >> [EMAIL PROTECTED]
>>>> >>
>>>> >>
>>>> >
>>>> >
>>>>
>>>> --
>>>> View this message in context:
>>>> http://www.nabble.com/-VOTE---Findbugs-xdoc-enhancement-tf4249607.html#a12112060
>>>> Sent from the mojo - dev mailing list archive at Nabble.com.
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe from this list please visit:
>>>>
>>>>     http://xircles.codehaus.org/manage_email
>>>>
>>>>
>>> 
>>> 
>> 
>> 
> 
> 

-- 
View this message in context: 
http://www.nabble.com/-VOTE---Findbugs-xdoc-enhancement-tf4249607.html#a12198280
Sent from the mojo - dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to