David Holroyd wrote:
I'd like to cut a 1.0 release of the plugin in its current state
+0, since I am not using the plugin.
Some side notes:
You could consider to inherit from the latest parent mojo:17 to benefit from
its improvements.
The plugin's site descriptor and index.html do not conform with the
development guidelines.
The POM snippets for the plugin usage do not include the <version> element
for the plugin which deviates from best practices.
There are Checkstyle/PMD issues.
Prefer "default-value" annotation for mojo parameters. Neither
@parameter expression="${basedir}/src/main/antlr"
nor
protected boolean debug = false;
will properly show up in the goal documentation, i.e. the user has no clue
what the plugin does by default.
shortIntoBuildOrder() sounds like a typo ("sort...")
Althought you use Java 1.4 compatible syntax, the plugin requires Java 1.5
to run. This should be documented, i.e. using the "target" option of the
compiler which should be picked up by the Maven Plugin Plugin 2.4 when
generating the plugin-info.html.
Benjamin
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
