On Sat, May 17, 2008 at 11:41:28AM +0200, Benjamin Bentmann wrote:
> David Holroyd wrote:
>
> >I'd like to cut a 1.0 release of the plugin in its current state
>
> +0, since I am not using the plugin.
>
> Some side notes:
>
> You could consider to inherit from the latest parent mojo:17 to benefit from
> its improvements.
Done.
> The plugin's site descriptor and index.html do not conform with the
> development guidelines.
Fixed. Thanks Dennis.
> The POM snippets for the plugin usage do not include the <version> element
> for the plugin which deviates from best practices.
Done.
> There are Checkstyle/PMD issues.
I've resolved the errors. I'll leave the warnings for now.
> Prefer "default-value" annotation for mojo parameters. Neither
> @parameter expression="${basedir}/src/main/antlr"
> nor
> protected boolean debug = false;
> will properly show up in the goal documentation, i.e. the user has no clue
> what the plugin does by default.
Dennis has taken care of this.
> shortIntoBuildOrder() sounds like a typo ("sort...")
Yep. Fixed.
> Althought you use Java 1.4 compatible syntax, the plugin requires Java 1.5
> to run. This should be documented, i.e. using the "target" option of the
> compiler which should be picked up by the Maven Plugin Plugin 2.4 when
> generating the plugin-info.html.
I replaced use of Collections.disjoint() with a.retainAll(b);
b.isEmpty(), and did a mvn clean verify with JDK1.4, so should be fine
to leave the target as it is.
Thanks Benjamin and Dennis for your help!
The vote is still open, with a little under a day remaining.
ta,
dave
--
http://david.holroyd.me.uk/
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
