Trygve Laugstøl wrote:
I would like to release a second alpha version of the solaris-maven-plugin.
0, not using it. Notes:
The plugin requires Java 1.5 to compile which might be unintentional
since not documented as such.
There are at least seven occurrences of the annotation "@read-only" on
mojo parameters which seem like typos (the Mojo API Spec only knows
"@readonly", i.e. without hyphen).
The plugin still inherits from Mojo parent 16 while version 17 is available.
The file xdoc/examples/myapp.xml points to an outdated link
(<snip>/sandbox/solaris/solaris-examples/myapp/). BTW, "here" is not an
expressive hyperlink text, maybe use "SVN repository" instead?
The POM snippet on the usage guide would benefit from showing a
<version> element for the plugin to demonstrate best practices.
"mvn docck:check" complains about the project.scm.url set to
"scm:svn:https://<snip>" which indeed causes a non-functional link on
the "Source Repository" report. This should be "http://<snip>" instead.
PMD reports an unused private field (PackagePkgMojo.mavenProjectHelper).
The deployed site might need some cleanup to save users from confusion.
For instance, Mojo's plugin list still points to
http://mojo.codehaus.org/solaris-maven-plugin/
while the recent plugin docs resides in
http://mojo.codehaus.org/solaris/solaris-maven-plugin/
I guess the former should be deleted and maybe replaced by a redirect?
Alternatively, you could adjust the distribution management of the
plugin to deploy to the old location.
Benjamin
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
