nicolas de loof wrote:

Folks, I've been working on the Sysdeo-Tomcat integration with Maven 2 and I
think its time for a new release.

0, not using it. The usual remarks:

The plugin requires Java 1.5 to compile, not sure if that is intentional. If, the corresponding config settings for the maven-compiler-plugin are missing.

The plugin could inherit from a newer Mojo parent (17).

The index page lists only one goal under the section "Goals" although the plugin has two goals.

The POM is missing the <issueManagement> section which causes the site to erroneously point at MOJO rather than MSYSDEO.

Likewise, the <scm> element is missing and resulting in a bad source repo report.

mvn docck:check reports some issues, most notably a missing <license> element, a missing <prerequisite> element and missing descriptions for the mojos themselves.

mvn dependency:analyze reports some problems.

PMD and Checkstyle report at least one non-cosmetic issue with a missing hashCode() impl for IdeDependency (BTW, the current equals() impl can throw ClassCastExceptions and NullPointerExceptions...)


Benjamin

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to