Hi David,
Revision
8033 <http://fisheye.codehaus.org/changelog/mojo/?cs=8033>
Author
david
Date
2008-11-10 17:01:35 -0600 (Mon, 10 Nov 2008)
[...]
+ String[] arguments = {
+ "-d=" + generatedSourcesLocation.getAbsolutePath(),
+ "-encoding=" + encoding,
+ status ? "-status" : "",
+ "-compile=false",
+ StringUtils.join( getSqljFiles().iterator(), " " )
+ };
If the space character is used as a separator, does that work with paths
that contain a space by themselves?
+ /**
+ * Codepage for generated sources.
+ *
+ * @parameter expression="${sqlj.encoding}" default-value="UTF-8"
+ */
+ private String encoding;
Some months ago there was a proposal to unify the encoding configuration
for source files [0]. I highly recommend its adoption to ensure the
plugin smoothly integrates into the Maven universe.
In short, the proposal suggests to
a) use the property "project.build.sourceEncoding" as default value
b) fallback to platform encoding in case the property is null/empty
For case b), it is also suggested to output a warning to the user to
indicate that the build output is platform-dependent.
+ mavenProject.getCompileSourceRoots().add(
generatedSourcesLocation.getAbsolutePath() );
There exists a dedicated MavenProject.addCompileSourceRoot() which is
preferable over directly manipulating the underlying collection. For
instance, it contains additional logic like checking for duplicates.
Benjamin
[0]
http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
